Skip to content

Commit

Permalink
Only display the number of users in breakout rooms list.
Browse files Browse the repository at this point in the history
  • Loading branch information
GhaziTriki committed Feb 8, 2016
1 parent c10beec commit da81a1b
Show file tree
Hide file tree
Showing 15 changed files with 37 additions and 88 deletions.
Expand Up @@ -62,9 +62,7 @@ class JsonMessageSenderActor(val service: MessageSender)
}

private def handleUpdateBreakoutUsers(msg: UpdateBreakoutUsersOutMessage) {
val users = new java.util.ArrayList[BreakoutUserPayload]()
msg.users.foreach(x => users.add(new BreakoutUserPayload(x.id, x.name)))
val payload = new UpdateBreakoutUsersPayload(msg.meetingId, msg.breakoutId, users)
val payload = new UpdateBreakoutUsersPayload(msg.meetingId, msg.breakoutId, msg.numberOfUsers)
val request = new UpdateBreakoutUsers(payload)
service.send(MessagingConstants.FROM_MEETING_CHANNEL, request.toJson())
}
Expand Down
Expand Up @@ -37,7 +37,7 @@ case class BreakoutRoomOutPayload(breakoutId: String, name: String, parentId: St
case class BreakoutRoomJoinURLOutMessage(meetingId: String, recorded: Boolean, breakoutId: String, userId: String, joinURL: String) extends IOutMessage
case class BreakoutRoomStartedOutMessage(meetingId: String, recorded: Boolean, breakout: BreakoutRoomBody) extends IOutMessage
case class BreakoutRoomBody(name: String, breakoutId: String)
case class UpdateBreakoutUsersOutMessage(meetingId: String, recorded: Boolean, breakoutId: String, users: Vector[BreakoutUser]) extends IOutMessage
case class UpdateBreakoutUsersOutMessage(meetingId: String, recorded: Boolean, breakoutId: String, numberOfUsers: Integer) extends IOutMessage
case class MeetingTimeRemainingUpdate(meetingId: String, recorded: Boolean, timeRemaining: Int) extends IOutMessage
case class BreakoutRoomEndedOutMessage(meetingId: String, breakoutId: String) extends IOutMessage

Expand Down
Expand Up @@ -88,7 +88,7 @@ trait BreakoutRoomApp extends SystemConfiguration {

def handleBreakoutRoomUsersUpdate(msg: BreakoutRoomUsersUpdate) {
breakoutModel.updateBreakoutUsers(msg.breakoutId, msg.users) foreach { room =>
outGW.send(new UpdateBreakoutUsersOutMessage(mProps.meetingID, mProps.recorded, msg.breakoutId, room.users))
outGW.send(new UpdateBreakoutUsersOutMessage(mProps.meetingID, mProps.recorded, msg.breakoutId, room.users.length))
}
}

Expand Down
Expand Up @@ -177,7 +177,7 @@ object MeetingMessageToJsonConverter {
payload.put("meetingId", msg.meetingId)
payload.put("breakoutId", msg.breakoutId)
payload.put("recorded", msg.recorded)
payload.put("users", msg.users.toArray)
payload.put("numberOfUsers", msg.numberOfUsers)

val header = Util.buildHeader(UpdateBreakoutUsers.NAME, None)
Util.buildJson(header, payload)
Expand Down
Expand Up @@ -6,19 +6,19 @@
import com.google.gson.Gson;

public class UpdateBreakoutUsers implements IBigBlueButtonMessage {
public final static String NAME = "UpdateBreakoutUsers";
public final Header header;
public final UpdateBreakoutUsersPayload payload;
public UpdateBreakoutUsers(UpdateBreakoutUsersPayload payload) {
this.header = new Header(NAME);
this.payload = payload;
}
public String toJson() {
Gson gson = new Gson();
return gson.toJson(this);
}
public final static String NAME = "UpdateBreakoutUsers";

public final Header header;
public final UpdateBreakoutUsersPayload payload;

public UpdateBreakoutUsers(UpdateBreakoutUsersPayload payload) {
this.header = new Header(NAME);
this.payload = payload;

}

public String toJson() {
Gson gson = new Gson();
return gson.toJson(this);
}
}
@@ -1,16 +1,15 @@
package org.bigbluebutton.messages.payload;

import java.util.ArrayList;

public class UpdateBreakoutUsersPayload {

public final ArrayList<BreakoutUserPayload> users;
public final String breakoutId;
public final String meetingId;

public UpdateBreakoutUsersPayload(String meetingId, String breakoutId, ArrayList<BreakoutUserPayload> users) {
this.meetingId = meetingId;
this.breakoutId = breakoutId;
this.users = users;
}
public final Integer numberOfUsers;
public final String breakoutId;
public final String meetingId;

public UpdateBreakoutUsersPayload(String meetingId, String breakoutId,
Integer numberOfUsers) {
this.meetingId = meetingId;
this.breakoutId = breakoutId;
this.numberOfUsers = numberOfUsers;
}
}
Expand Up @@ -564,7 +564,7 @@ private void processUpdateBreakoutUsers(UpdateBreakoutUsers msg) {
Map<String, Object> args = new HashMap<String, Object>();
args.put("meetingId", msg.payload.meetingId);
args.put("breakoutId", msg.payload.breakoutId);
args.put("users", msg.payload.users);
args.put("numberOfUsers", msg.payload.numberOfUsers);

Map<String, Object> message = new HashMap<String, Object>();
Gson gson = new Gson();
Expand Down
3 changes: 0 additions & 3 deletions bigbluebutton-client/src/org/bigbluebutton/common/Images.as
Expand Up @@ -133,9 +133,6 @@ package org.bigbluebutton.common
[Embed(source="assets/images/user.png")]
public var user:Class;

[Embed(source="assets/images/users.png")]
public var users:Class;

[Embed(source="assets/images/administrator.gif")]
public var admin:Class;

Expand Down
Binary file not shown.
Expand Up @@ -18,8 +18,6 @@
*/
package org.bigbluebutton.main.model.users {

import mx.collections.ArrayCollection;

[Bindable]
public class BreakoutRoom {
public static const NONE:String = "none";
Expand All @@ -32,13 +30,9 @@ package org.bigbluebutton.main.model.users {

public var name:String;

public var users:ArrayCollection;
public var numberOfUsers:int;

// Can be one of three following values self, none, other
public var listenStatus:String = NONE;

public function BreakoutRoom() {
users = new ArrayCollection();
}
}
}
Expand Up @@ -536,10 +536,10 @@ package org.bigbluebutton.main.model.users {
breakoutRooms.refresh();
}

public function updateBreakoutRoomUsers(breakoutId:String, users:Array):void {
public function updateBreakoutRoomUsers(breakoutId:String, users:int):void {
var room:Object = getBreakoutRoom(breakoutId);
if (room!= null) {
BreakoutRoom(room).users = new ArrayCollection(users);
if (room != null) {
BreakoutRoom(room).numberOfUsers = users;
}
}

Expand Down
Expand Up @@ -617,7 +617,7 @@ package org.bigbluebutton.modules.users.services

private function handleUpdateBreakoutUsers(msg:Object):void{
var map:Object = JSON.parse(msg.msg);
UserManager.getInstance().getConference().updateBreakoutRoomUsers(map.breakoutId, map.users);
UserManager.getInstance().getConference().updateBreakoutRoomUsers(map.breakoutId, map.numberOfUsers);
}

private function handleTimeRemainingUpdate(msg:Object):void{
Expand Down
Expand Up @@ -33,7 +33,7 @@

<mx:Button id="listenBtn" toggle="true"
width="20" height="20"
icon="{images.transfer}" toolTip="{ResourceUtil.getInstance().getString('bbb.users.roomsGrid.listen')}"
icon="{images.transfer}" toolTip="{ResourceUtil.getInstance().getString('bbb.users.roomsGrid.transfer')}"
click="listenToBreakoutRoom(event)" visible="{data.listenStatus != BreakoutRoom.OTHER}"/>
<mx:Button id="joinImg" width="20" height="20"
icon="{images.join}" toolTip="{ResourceUtil.getInstance().getString('bbb.users.roomsGrid.join')}"
Expand Down

This file was deleted.

Expand Up @@ -563,8 +563,7 @@
dragEnabled="false" width="100%" height="100%" draggableColumns="false">
<mx:columns>
<mx:DataGridColumn dataField="name" headerText="{ResourceUtil.getInstance().getString('bbb.users.roomsGrid.room')}" />
<mx:DataGridColumn dataField="users" headerText="{ResourceUtil.getInstance().getString('bbb.users.roomsGrid.users')}"
itemRenderer="org.bigbluebutton.modules.users.views.RoomUsersRenderer"/>
<mx:DataGridColumn dataField="numberOfUsers" headerText="{ResourceUtil.getInstance().getString('bbb.users.roomsGrid.users')}"/>
<mx:DataGridColumn dataField="breakoutId" headerText="{ResourceUtil.getInstance().getString('bbb.users.roomsGrid.action')}"
itemRenderer="org.bigbluebutton.modules.users.views.RoomActionsRenderer"/>
</mx:columns>
Expand Down

0 comments on commit da81a1b

Please sign in to comment.