Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ejecting a user sends both user ejected and user removed messages #12080

Closed
antobinary opened this issue Apr 19, 2021 · 2 comments · Fixed by #14385
Closed

Ejecting a user sends both user ejected and user removed messages #12080

antobinary opened this issue Apr 19, 2021 · 2 comments · Fixed by #14385

Comments

@antobinary
Copy link
Member

Ejecting a user sends both user ejected and user removed messages via PubSub.

This leads to bbb-html5 having to jump through hoops to be able to inform the user with the correct info.
It would be simpler if ejecting user only dispatched user ejected message (not user removed message which is linked to different flows)

Related:
#12057

@antobinary
Copy link
Member Author

I believe this is resolved but let's confirm in 2.4 to be sure

@antobinary antobinary modified the milestones: Release 2.4, Release 2.5 Feb 11, 2022
@antobinary
Copy link
Member Author

After a chat with @Tainan404 he recommended we merge the eject message into the remove message by adding a new field (or two?) -- reason for removal

Let's make sure we also handle the ban use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants