Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removeUser - handle connections in frontends, db changes in backend #12695

Merged
merged 1 commit into from Jun 30, 2021

Conversation

antobinary
Copy link
Member

What does this PR do?

Reorganized the handling of UserLeftMeetingEvtMsg by bbb-html5 so that the backends handle processing to update MongoDB and the frontends handle processing to update the ClientConnections. This way there's no overlap/unpredictability

  • split the handling of logic for UserLeft message - backend handles the updates for Mongo, frontend handles the updates to ClientConnections

  • removed the 1 second delay since now only backend handles the userleft+user ejected messages and they are syncronous

  • no longer initialize ClientConnections on backend instances

Closes Issue(s)

Closes #12080 since we are now guaranteed to be processing sequentially the two relevant events in a single NodeJS instance:

Jun 30 20:04:35 anton.vm systemd_start.sh[36803]: warn: Received event to handle {"date":"2021-06-30T20:04:35.385Z","eventName":"UserEjectedFromMeetingEvtMsg"}
Jun 30 20:04:35 anton.vm systemd_start.sh[36803]: warn: Received event to handle {"date":"2021-06-30T20:04:35.386Z","eventName":"UserLeftMeetingEvtMsg"}

Motivation

We were looking into ways to remove the 1000 ms delay added in #12057 and particularly why the re-ordering of events processing was happening.

@antobinary antobinary added this to the Release 2.3 milestone Jun 30, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@antobinary antobinary merged commit 4a1e43c into bigbluebutton:v2.3.x-release Jun 30, 2021
@mabras
Copy link

mabras commented Jul 3, 2021

Hello @antobinary ,

We were testing this in our env.

If the moderator removes a viewer, the viewer's client will throw an exception and the app crashed.
image

This where the error happens:

  // THIS LINE:
  if (meeting.lockSettingsProps.hideUserList && currentUser.role === USER_CONFIG.role_viewer) {
    selector.role = { $ne: USER_CONFIG.role_viewer };
  }

It sounds to me it is related to hiding the user list. Actully we do hide the user list:

sed -i 's/lockSettingsHideUserList=.*/lockSettingsHideUserList=true/g' /usr/share/bbb-web/WEB-INF/classes/bigbluebutton.properties

Reverting this commit solves the issue.
showing the user list also solves the issue.

Thanks,

@antobinary
Copy link
Member Author

Thanks for reporting this @mabras

I am able to reproduce, opened #12714 (comment)
It might be related to #12691

@antobinary antobinary deleted the user-left branch October 29, 2021 13:00
@antobinary antobinary modified the milestones: Release 2.3, Release 2.5 Nov 30, 2021
@antobinary antobinary modified the milestones: Release 2.5, Release 2.3 Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants