Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent screen share cropping on chrome 84 #10099

Merged

Conversation

KDSBrowne
Copy link
Collaborator

What does this PR do?

Adds height: 100% to screenshareVideo element

Closes Issue(s)

#9735

@ffdixon ffdixon merged commit eb1624a into bigbluebutton:v2.2.x-release Jul 21, 2020
@matiasilva
Copy link
Collaborator

Does the issue need closing? :-)

@antobinary antobinary added this to the Release 2.2 milestone Jul 21, 2020
@callumlew
Copy link

I've updated our BBB site to the latest version using the install script but this has not corrected the issue.
Are we able to add this to current deployments? If so what file would I need to update?

Thanks
Callum

@ffdixon
Copy link
Member

ffdixon commented Jul 27, 2020

We have this fixed in the upcoming 2.2.21, which you can try now on https://demo.bigbluebutton.org/. Please try it there and let us now if the screen sharing is no longer cropped on Chrome 84.

@callumlew
Copy link

Hi @ffdixon
I can confirm the issue is resoled.
When will the 2.2.21 release be released as stable?

Is there any change I can make to the current deployment as it is causing us some issues?

@KDSBrowne KDSBrowne deleted the screenshare-crop-fix branch September 3, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants