Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when alternate panel. Fix external video size #10341

Merged
merged 2 commits into from Sep 11, 2020
Merged

Fix bug when alternate panel. Fix external video size #10341

merged 2 commits into from Sep 11, 2020

Conversation

vitormateusalmeida
Copy link
Contributor

Closes #10339
Closes #10340

KDSBrowne
KDSBrowne suggested changes Aug 27, 2020
View reviewed changes
Copy link
Collaborator

@KDSBrowne KDSBrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opening the breakoutroom panel is taking multiple click's.
panel_bug

I would have thought the layout manager would wrap the components that make up the interface and update them using props / state. instead of relying on window event listeners.

@vitormateusalmeida
Copy link
Contributor Author

vitormateusalmeida commented Sep 4, 2020 •
edited

opening the breakoutroom panel is taking multiple click's.

Bug fixed in last commit

I would have thought the layout manager would wrap the components that make up the interface and update them using props / state. instead of relying on window event listeners.

This will be approach in #10395

@vitormateusalmeida vitormateusalmeida mentioned this pull request Sep 8, 2020
Closed
KDSBrowne
KDSBrowne approved these changes Sep 8, 2020
View reviewed changes
Copy link
Collaborator

@KDSBrowne KDSBrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, couldn't reproduce the issues mentioned.

@KDSBrowne
Copy link
Collaborator

KDSBrowne commented Sep 8, 2020 •
edited

Not sure if the nullish coalescing operator (?.) will cause an issue in production. I recall trying to use it and it throwing an error.

@antobinary antobinary merged commit 1d86d0e into bigbluebutton:develop Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KDSBrowne KDSBrowne KDSBrowne approved these changes

Assignees
No one assigned
Labels
module: client
Projects
None yet
Milestone
No milestone
3 participants
@vitormateusalmeida @KDSBrowne @antobinary