Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error in Bezier.java #10554

Merged
merged 3 commits into from Sep 30, 2020
Merged

Conversation

hiroshisuga
Copy link
Contributor

What does this PR do?

Fixes compile error occurs at two special characters.

Closes Issue(s)

closes #...

Motivation

Probably depending on the locale of terminal where I compile the source code, I sometimes experienced compile errors.

More

I am not 100% sure if I am right in the second fix of the formula.

@antobinary
Copy link
Member

Hi @hiroshisuga
I would think that just replacing the degree symbol would suffice in the second formula, you could keep the rad

If you still have the console errors, please share them here so others could search and find for future reference

@hiroshisuga
Copy link
Contributor Author

hiroshisuga commented Sep 30, 2020

Thanks for the suggestion. I changed.

BTW I do not really understand this formula: 44 deg = 44 * 180d / Math.PI.
This simply indicates how to convert radian to degree, and what the sentence wants to say is that 44 degree ( = 0.768 radian) is recommended. Thus 44 deg = 0.768 rad * 180d / Math.PI makes more sense at least to me...

@antobinary antobinary merged commit 3c40c00 into bigbluebutton:develop Sep 30, 2020
@hiroshisuga hiroshisuga deleted the patch-5 branch June 26, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants