[Mobile] - Setting or clearing user status locks the whole screen #10702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On mobile if you clicked on a user or your own user to set their status, the tethered modal would keep it's z-index, which would prevent the user from interacting with anything because the tethered modal would overlap the whole site.
KDSBrowne
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On mobile if you clicked on a user or your own user to set their status, the tethered modal would keep it's z-index (15), which would prevent the user from interacting with anything because the tethered modal would overlap the whole site.
I think strictly comparing keepOpen variable to null was done mistakenly as the keepOpen variable is either true or false and that was the reason the modal didn't close after setting or clearing user status.
Closes Issue(s)
closes #...
Haven't found any issues about this problem
Motivation
After work debugging