secure http in application.conf #11032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, this is just a placeholder URL. Every time I work on akka-apps (specifically Breakouts) I replace the entire URL with my server's The placeholder contains the local IP of one of the devs from years ago 😊 I will merge this PR as it might be making it a bit less confusing, but keep in mind that everyone doing work in the area will still need to modify this line, albeit a smaller portion of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
change http -> https at services-bbbWebAPI.
Closes Issue(s)
Motivation
Most of the users, especially those who tweak the source code of akka-bbb-apps, should be using https.
http at this place prevents to start breakout room under a modified akka-bbb-apps in BBB 2.2 (2.3 seems to be OK). Setting https as a default value would be less confusing.
More
I am not sure if this problem is universal or specific to my server.