video-preview: improvements to error handling (#9943) and cleanups #11068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w component. fix wrong file permission.
The first getUserMedia was not supposed to be considered critical to the whole video preview flow. Scenarios where the user has multiple media sources and one of them was already in use or had some malfunction problem were forcing a global skip at the video preview modal even if one of them was available to be used.
Some browsers seem to (occasionally) not return the getUserMedia promise call and the user gets stuck in this state unable to share her/his webcam. Since enumerateDevices still works even on a gUM rejection this includes a racing timeout that skips gUM. Configured at settings `gUMTimeout`. Reproduced with Windows 10 Chrome 87.
Otherwise users who took long enough to accept the gUM permission prompt would fall into the workaround
It seems the video-preview generic error fallback locale (to handle unexpected errors on our side which do not inherently come from gUM calls) was removed by accident. Adding it back.
This was referenced Jan 27, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a port of a work done by @CristianSilvaGrosseli and @pedrobmarin that improves overall video-preview error handling, display and code quality. In detail:
Finding webcams...state, rendering it useless even if you had a second working camera to useMeteor.settings.public.kurento.gUMTimeout). When the timeout expires, an error is shown in the UI and the rest of the devices are enumerated and iterated upon.Infinity.Closes Issue(s)
closes #9943
More
Co-authored-by @CristianSilvaGrosseli
Co-authored-by: @pedrobmarin