Allow audio constraints to be changed in bbb-html5's settings.yml #11143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some scenarios, there's no need for the browser to apply such audio filters. For example, when user's microphone already does audio filtering (echo cancellation, noise supression ...). This commit doens't change the current behavior (filters still follow browser's default config): admins need to uncomment/set these values if disabling/enabling specific filters if desired. This is related to bigbluebutton#4873
mariogasparoni
added a commit
to mariogasparoni/bigbluebutton
that referenced
this pull request
Jan 22, 2021
As explained in bigbluebutton#11143, disabling audio filters is desired in some scenarios. This basically adds an option for user to disable default constraints. When user doesn't change this value in Settings > Application, the default value for each audio constraints is retrieved from settings.yml. When user changes this value in Settings > Application, audio filters (AGC, Noise Supression and Echo Cancellation) are all set to true/false, according to the value selected in the Settings GUI. To start it simple, we decided to not to add a different setting in the GUI for each audio contraint. This may be added in the future, though (perhaps in a dedicated Audio Settings tab) This is related to bigbluebutton#4873
mariogasparoni
added a commit
to mariogasparoni/bigbluebutton
that referenced
this pull request
Jan 29, 2021
As explained in bigbluebutton#11143, disabling audio filters is desired in some scenarios. This basically adds an option for user to disable default constraints. When user doesn't change this value in Settings > Application, the default value for each audio constraints is retrieved from settings.yml. When user changes this value in Settings > Application, audio filters (AGC, Noise Supression and Echo Cancellation) are all set to true/false, according to the value selected in the Settings GUI. To start it simple, we decided to not to add a different setting in the GUI for each audio contraint. This may be added in the future, though (perhaps in a dedicated Audio Settings tab) This is related to bigbluebutton#4873
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some scenarios, there's no need for the browser to apply such audio filters. For example, when user's microphone already does audio filtering (echo cancellation, noise supression ...).
This commit doens't change the current behavior (filters still follow browser's default config): admins need to uncomment/set these values if disabling/enabling specific filters if desired.
This is related to #4873