Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat with adapter and context #11173

Merged
merged 20 commits into from Feb 12, 2021
Merged

Chat with adapter and context #11173

merged 20 commits into from Feb 12, 2021

Conversation

Tainan404
Copy link
Member

What does this PR do?

This PR adds a middleware between mini-mongo and react data using context.

Closes Issue(s)

Closes issue #8554

@TiagoJacobs
Copy link
Member

Can you please squash this commits @Tainan404 ?

TiagoJacobs
TiagoJacobs requested changes Jan 18, 2021
View reviewed changes
Copy link
Member

@TiagoJacobs TiagoJacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=> Squash commits;
=> Check for the console.logs ( all logs must use the logger );

prlanzarin
prlanzarin reviewed Jan 19, 2021
View reviewed changes
Copy link
Member

@prlanzarin prlanzarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving some suggestions from a very quick vertical read of some (~1/5) of the code.

bigbluebutton-html5/imports/startup/server/index.js Outdated Show resolved Hide resolved
bigbluebutton-html5/imports/ui/components/chat/chat-logger/ChatLogger.js Show resolved Hide resolved
bigbluebutton-html5/imports/startup/client/base.jsx Outdated Show resolved Hide resolved
bigbluebutton-html5/imports/startup/client/base.jsx Outdated Show resolved Hide resolved
bigbluebutton-html5/package.json Outdated Show resolved Hide resolved
bigbluebutton-html5/imports/ui/components/subscriptions/component.jsx Outdated Show resolved Hide resolved
bigbluebutton-html5/imports/ui/components/chat/container.jsx Outdated Show resolved Hide resolved
bigbluebutton-html5/imports/ui/components/chat/service.js Outdated Show resolved Hide resolved
bigbluebutton-html5/imports/ui/components/media/webcam-draggable-overlay/context.jsx Outdated Show resolved Hide resolved
@Tainan404 Tainan404 marked this pull request as draft January 26, 2021 14:39
@ramonlsouza ramonlsouza mentioned this pull request Jan 29, 2021
Merged
@Tainan404 Tainan404 mentioned this pull request Feb 4, 2021
Merged
This was referenced Feb 9, 2021
Closed
Closed
@daminebenq daminebenq mentioned this pull request Feb 10, 2021
Merged
@daminebenq daminebenq mentioned this pull request Feb 12, 2021
Closed
@antobinary antobinary marked this pull request as ready for review February 12, 2021 21:19
@antobinary antobinary merged commit 1476deb into bigbluebutton:develop Feb 12, 2021
@daminebenq daminebenq mentioned this pull request Feb 18, 2021
Closed
@daminebenq daminebenq mentioned this pull request Mar 12, 2021
Closed
@prlanzarin prlanzarin mentioned this pull request Apr 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TiagoJacobs TiagoJacobs TiagoJacobs requested changes

@prlanzarin prlanzarin prlanzarin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Tainan404 @TiagoJacobs @prlanzarin @antobinary