Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set safe default values for slide position (WIP) #11298

Merged
merged 2 commits into from Feb 11, 2021

Conversation

ramonlsouza
Copy link
Member

@ramonlsouza ramonlsouza commented Feb 3, 2021

What does this PR do?

Fixes slide position bug described on issue #11270 by checking if slide position values exist.

Closes Issue(s)

closes #11270


if (!positions) {
return {
width: 1000, height: 1000, x: 0, y: 0, viewBoxWidth: 1000, viewBoxHeight: 1000,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ramonlsouza
Is there a reference or justification for using those specific values as default? Could they include other type of issues in the components?

@ramonlsouza ramonlsouza changed the title Set safe default values for slide position Set safe default values for slide position (WIP) Feb 3, 2021
@ramonlsouza
Copy link
Member Author

@ffdixon can you try this solution?

I'm still not able to reproduce the error without setting variables to null, so I'm not sure that checking for width/height is enough

@antobinary antobinary added this to the Release 2.3 milestone Feb 11, 2021
@antobinary antobinary merged commit 39759c7 into bigbluebutton:develop Feb 11, 2021
@zbles
Copy link

zbles commented Jan 3, 2022

I have the same problem with BigBlueButton 2.4. Short and simple presentations load and play without problems, but longer and more complicated generate error
"app.error.fallback.view.title
app.error.fallback.view.description
Cannot read properties of undefined (reading 'width')"
Is this solution OK for BBB 2.4? How can I make necessary modyfications on workings system without reinstalling from a source code?

@ffdixon
Copy link
Member

ffdixon commented Jan 3, 2022

If you can provide steps to reproduce on https://demo.bigbluebutton.org/, that would be great.

@zbles
Copy link

zbles commented Jan 7, 2022

I can't get this error on BBB demo site. My bbb was installed with the standard installer. Everything according to the documentation. There is nothing else on the server. I do not see any errors in the logs that could indicate the source of the problem. The problem described above appears only when uploading longer presentations. It looks like the whole upload and conversion process is done without a problem, but then there is a black screen for a long time instead of the presentation. After literally a few minutes, the bottom bar itself appears with the slide number, but there is no content above (it will give a black screen). After collapsing and redrawing the presentation, the following message appears:
app.error.fallback.view.title
app.error.fallback.view.description
Cannot read properties of undefined (reading 'width')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app.error.fallback.view.title in new session
5 participants