New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set safe default values for slide position (WIP) #11298
Conversation
|
||
if (!positions) { | ||
return { | ||
width: 1000, height: 1000, x: 0, y: 0, viewBoxWidth: 1000, viewBoxHeight: 1000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ramonlsouza
Is there a reference or justification for using those specific values as default? Could they include other type of issues in the components?
@ffdixon can you try this solution? I'm still not able to reproduce the error without setting variables to null, so I'm not sure that checking for width/height is enough |
I have the same problem with BigBlueButton 2.4. Short and simple presentations load and play without problems, but longer and more complicated generate error |
If you can provide steps to reproduce on https://demo.bigbluebutton.org/, that would be great. |
I can't get this error on BBB demo site. My bbb was installed with the standard installer. Everything according to the documentation. There is nothing else on the server. I do not see any errors in the logs that could indicate the source of the problem. The problem described above appears only when uploading longer presentations. It looks like the whole upload and conversion process is done without a problem, but then there is a black screen for a long time instead of the presentation. After literally a few minutes, the bottom bar itself appears with the slide number, but there is no content above (it will give a black screen). After collapsing and redrawing the presentation, the following message appears: |
What does this PR do?
Fixes slide position bug described on issue #11270 by checking if slide position values exist.
Closes Issue(s)
closes #11270