Display polling buttons on fullscreen presentation #11319
Conversation
| /> | ||
| </div> | ||
| <> | ||
| {isFullscreen && <PollingContainer />} |
There was a problem hiding this comment.
I'm not sure this is the best place to render the PollingContainer. It might make more sense to render this in the parent element that is being set to full-screen instead of the FullscreenButtonComponent
There was a problem hiding this comment.
moved pollingContainer to PresentationArea, and removed the duplicated component when in fullscreen
…d component in fullscreen
|
The polling options don't seem to appear if the app is set to full-screen via the settings option
|
fixed on last commit (pollingContainer will now hide/show if presentation is fullscreen instead of any element is fullscreen). |
|
I would like the random viewer selection modal to be fixed as well. |
|
I would like to show the poll window also on the full-screen shared screen. |
What does this PR do?
Improves presentation fullscreen experience by correctly displaying polling buttons (adding a
PollingContainerto thefullscreenButtoncomponent, and setting it to render only on fullscreen).Modern browsers set the z-index of fullscreened elements to 2147483647 (the largest 32-bit signed number), so the best solution to display another element in fullscreen is to put them on a container, and set the container to fullscreen.
Closes Issue(s)
closes #10783