Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user-sent poll result messages #11415

Closed
wants to merge 1 commit into from

Conversation

ramonlsouza
Copy link
Member

@ramonlsouza ramonlsouza commented Feb 17, 2021

What does this PR do?

Prevents user messages containing bbb-published-poll- from being displayed as poll results, by changing the way poll result messages are parsed before being displayed on chat.

New poll result message

Screenshot from 2021-02-17 17-33-06

If a user send a message containing bbb-published-poll- now, it will be displayed as any other user message

Screenshot from 2021-02-17 17-30-40

Closes Issue(s)

closes #11393

@pedrobmarin
Copy link
Collaborator

Hi @ramonlsouza ,

I see how this can avoid the problem right now but it does not solve the bigger issue that is having the poll tag at the chat's message content. This should be at least associated with a new issue to tackle all the changes this feature need to be production ready.

@github-actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@daminebenq
Copy link
Contributor

daminebenq commented Feb 18, 2021

Hi @ramonlsouza
I just tested this, and I found the following:

the bbb-published-poll- tag is completely ignored now when sent from a user wich is fixing the main problem, but there are other stuff broken by the PR..

deepin-screen-recorder_Select.area_20210218181636.mp4

in the video recorded above, the polling options don't appear at all after choosing what options to ask in the poll.

expected apparance:
image

current behavior:
image

@ramonlsouza
Copy link
Member Author

Thanks for the review @daminebenq

Looks like another PR related to polls was approved before mine, and changed the way polls work on the back-end...

I'm fixing this and will send a new commit soon

@ramonlsouza
Copy link
Member Author

conflicts resolved on #11437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants