Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip publishing poll annotation to whiteboard if presentation swapped #11417

Merged
merged 1 commit into from Feb 18, 2021

Conversation

KDSBrowne
Copy link
Collaborator

@KDSBrowne KDSBrowne commented Feb 17, 2021

What does this PR do?

This PR skips calculating / rendering the poll results to the whiteboard for the specific user who may have a swapped presentation. I suspect this will be a temporary solution until the poll annotation calculations are moved from the client side.

Closes Issue(s)

Closes #11097

@daminebenq
Copy link
Contributor

is this considering userdata-bbb_force_restore_presentation_on_new_events=true customparameter and not breaking it ?

@daminebenq
Copy link
Contributor

Hi @KDSBrowne
just testing this PR with userdata-bbb_force_restore_presentation_on_new_events=true.
the result was the following:
image
So, what i understood is, in case of Whiteboard is minimized, the polling results won't show at all. right ?

@KDSBrowne
Copy link
Collaborator Author

@daminebenq userdata-bbb_force_restore_presentation_on_new_events=true was intended to restore the presentation after new events happened. So the intended behavior is still correct, the reason the poll annotation does not get rendered while userdata-bbb_force_restore_presentation_on_new_events=true when minimized on publish is because the annotation size calculations happen before the event.

@antobinary antobinary merged commit d686f0b into bigbluebutton:develop Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publishing survey results when a presentation is hidden - 2.3 alpha4
3 participants