User logged out ValidateAuthToken retracted #11607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o user-logged-out
… to response message
jfsiebel
approved these changes
Mar 11, 2021
… to response message
…into user-logged-out
|
Out of sync changes. |
|
Should be good now @aron-2809 . May we merge? |
|
@antobinary and @jfsiebel There is one more change needed in the client. The client needs to handle the rejection and display a proper notification to the user. Currently, it just displays the "..." message which would give the impression that the client is still trying to connect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR provides the backend logic required to support User logged out flow to prevent from rejoining by copy/paste url.
Closes Issue(s)
closes # 11220 #11220
More
validateauthtoken now contains the reason, the ui should determine how to present it to user.