Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create meeting message order precedes group chat message in akka… #11650

Merged

Conversation

aron-2809
Copy link
Contributor

@aron-2809 aron-2809 commented Mar 15, 2021

…-apps

What does this PR do?

This PR moves create meeting message from BBB actor to meeting actor in order to maintain the message sequences.

Motivation

Meeting created event message should precede group chat message for compatibility reasons with UI.

@aron-2809
Copy link
Contributor Author

@ritzalam @antobinary

@antobinary antobinary self-requested a review March 15, 2021 22:43
@antobinary
Copy link
Member

Pulled, rebuilt bbb-apps-akka, tested:

✔️ MeetingCreatedEvtMsg is received before any other event on the from-akka-apps-redis-channel channel

Thank you!!

1) "pmessage"
2) "from-akka-apps*"
3) "from-akka-apps-redis-channel"
4) "{\"envelope\":{\"name\":\"MeetingCreatedEvtMsg\",\"routing\":{\"sender\":\"bbb-apps-akka\"},\"timestamp\":1615848834470},\"core\":{\"header\":{\"name\":\"MeetingCreatedEvtMsg\"},\"body\":{\"props\":{\"meetingProp\":{\"name\":\"random-6978151\",\"extId\":\"random-6978151\",\"intId\":\"b40ce09e9ff075c01e86c60b319829e287bec00d-1615848834423\",\"isBreakout\":false},\"breakoutProps\":{\"parentId\":\"bbb-none\",\"sequence\":0,\"freeJoin\":false,\"breakoutRooms\":[],\"enabled\":true,\"record\":false,\"privateChatEnabled\":true},\"durationProps\":{\"duration\":0,\"createdTime\":1615848834423,\"createdDate\":\"Mon Mar 15 22:53:54 UTC 2021\",\"meetingExpireIfNoUserJoinedInMinutes\":5,\"meetingExpireWhenLastUserLeftInMinutes\":1,\"userInactivityInspectTimerInMinutes\":0,\"userInactivityThresholdInMinutes\":30,\"userActivitySignResponseDelayInMinutes\":5},\"password\":{\"moderatorPass\":\"mp\",\"viewerPass\":\"ap\"},\"recordProp\":{\"record\":false,\"autoStartRecording\":false,\"allowStartStopRecording\":true,\"keepEvents\":true},\"welcomeProp\":{\"welcomeMsgTemplate\":\"<br>Welcome to <b>%%CONFNAME%%</b>!<br><br>This server is running <a href=\\\"https://docs.bigbluebutton.org/\\\" target=\\\"_blank\\\"><u>BigBlueButton</u></a>.\",\"welcomeMsg\":\"<br>Welcome to <b>random-6978151</b>!<br><br>This server is running <a href=\\\"https://docs.bigbluebutton.org/\\\" target=\\\"_blank\\\"><u>BigBlueButton</u></a>.\",\"modOnlyMessage\":\"\"},\"voiceProp\":{\"telVoice\":\"70895\",\"voiceConf\":\"70895\",\"dialNumber\":\"613-555-1234\",\"muteOnStart\":false},\"usersProp\":{\"maxUsers\":0,\"webcamsOnlyForModerator\":false,\"guestPolicy\":\"ASK_MODERATOR\",\"allowModsToUnmuteUsers\":false,\"authenticatedGuest\":true},\"metadataProp\":{\"metadata\":{}},\"screenshareProps\":{\"screenshareConf\":\"70895-SCREENSHARE\",\"red5ScreenshareIp\":\"anton23.blindside-dev.com\",\"red5ScreenshareApp\":\"video-broadcast\"},\"lockSettingsProps\":{\"disableCam\":false,\"disableMic\":false,\"disablePrivateChat\":false,\"disablePublicChat\":false,\"disableNote\":false,\"hideUserList\":false,\"lockedLayout\":false,\"lockOnJoin\":true,\"lockOnJoinConfigurable\":false},\"systemProps\":{\"html5InstanceId\":1}}}}}"
1) "pmessage"
2) "from-akka-apps*"
3) "from-akka-apps-redis-channel"
4) "{\"envelope\":{\"name\":\"GroupChatCreatedEvtMsg\",\"routing\":{\"msgType\":\"BROADCAST_TO_MEETING\",\"meetingId\":\"b40ce09e9ff075c01e86c60b319829e287bec00d-1615848834423\",\"userId\":\"SYSTEM\"},\"timestamp\":1615848834470},\"core\":{\"header\":{\"name\":\"GroupChatCreatedEvtMsg\",\"meetingId\":\"b40ce09e9ff075c01e86c60b319829e287bec00d-1615848834423\",\"userId\":\"SYSTEM\"},\"body\":{\"correlationId\":\"SYSTEM-1615848834470\",\"chatId\":\"MAIN-PUBLIC-GROUP-CHAT\",\"createdBy\":{\"id\":\"SYSTEM\",\"name\":\"SYSTEM\"},\"name\":\"MAIN-PUBLIC-GROUP-CHAT\",\"access\":\"PUBLIC_ACCESS\",\"users\":[],\"msg\":[]}}}"
1) "pmessage"
2) "from-akka-apps*"
3) "from-akka-apps-redis-channel"
4) "{\"envelope\":{\"name\":\"CreateNewPresentationPodEvtMsg\",\"routing\":{\"msgType\":\"BROADCAST_TO_MEETING\",\"meetingId\":\"b40ce09e9ff075c01e86c60b319829e287bec00d-1615848834423\",\"userId\":\"SYSTEM\"},\"timestamp\":1615848834470},\"core\":{\"header\":{\"name\":\"CreateNewPresentationPodEvtMsg\",\"meetingId\":\"b40ce09e9ff075c01e86c60b319829e287bec00d-1615848834423\",\"userId\":\"SYSTEM\"},\"body\":{\"currentPresenterId\":\"\",\"podId\":\"DEFAULT_PRESENTATION_POD\"}}}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants