feat(external videos): back end improvements #12504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the external videos collection, moving the logic and functionalities outside of /imports/api/meetings to a new location in /external-videos/server/modifiers in order to decrease the coupling between the functionalities, favoring the maintenance.
Checks permission of start, stop and update external video messages and only broadcast it if the sender is presenter (unless it's system messages).
Revoked extra frontend permission checks and removed dependency from external video stop Meteor's system call.
Move all external video's system stop control events to akka-apps: - on presenter change - on presenter leave - on screenshare start
A media state may have more than 2 states. Moving this property back to integer so it can be extended.
antobinary
reviewed
Jun 4, 2021
|
|
||
| const externalVideoUrl = body.externalVideoUrl; | ||
| const user = Users.findOne({ meetingId: meetingId, userId: userId }) | ||
| const { userId } = header; |
There was a problem hiding this comment.
We don't check if userId and externalVideoUrl are strings neither here nor in akka-apps, we just start using them (unless I am missing to read some spot)
antobinary
reviewed
Jun 4, 2021
| check(meetingId, String); | ||
| check(userId, String); | ||
| check(requesterUserId, String); | ||
| check(externalVideoUrl, String); |
There was a problem hiding this comment.
We check here but not on startExternalVideo. Is this sufficient?
There was a problem hiding this comment.
We pushed those checks to the modifier but the userId is missing, indeed.
antobinary
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked some improvements we've been doing to the external videos feature.
Kudos to @frankemax and @Arthurk12