fix: add minimum duration for breakout room #12560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
antobinary
approved these changes
Jun 14, 2021
|
Test reproducing fix ✔️ Video: test-12560.mp4A few issues/improvements: 1 - When the input value is null, the increase and decrease buttons doesn't work: testing-buttons.mp42 - If set the minimum value clicking in the increase button, it keeps showing the minimum duration error message: Peek.2021-06-15.09-44.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevents the user from creating a breakout room with a duration shorter than the minimum (5 minutes).
Closes Issue(s)
Closes #12557