Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick poll showing option texts (up to 99 items) #12590

Closed

Conversation

hiroshisuga
Copy link
Contributor

@hiroshisuga hiroshisuga commented Jun 15, 2021

What does this PR do?

Shows option texts for quick polling.
This is a resubmission of #10854, which has been broken after mistakenly following the 2.4.x development.

Closes Issue(s)

closes #10631 , Related to #10771

Motivation

Current quick polling does not show the option (answer) text, and sometimes hides the slide (where the questions and options are written) on the smartphone, so students cannot answer when they forget their choice. I, as a professor, have to warn them "Do you already know your choice? Please don't forget it, OK, let's move to the poll, put your choice before you forget it" ;-)
This PR enables BBB to read the slide text and show the poll option texts, by simply using the BBB's custom polling function.
At last, I've realised that BBB accepts 6 options in one place, while accepting up to 5 options in another. I modified the numChar variable in quick-poll-dropdown/component.jsx to accept up to 6 options.

More

I have posted another PR (#10855) doing the same thing for BBB 2.2, just in case somebody finds it useful.

wb

@hiroshisuga hiroshisuga marked this pull request as draft June 18, 2021 00:47
@hiroshisuga
Copy link
Contributor Author

hiroshisuga commented Jun 18, 2021

I changed this to draft. Now, when the polling options are written in numbering (ie, 1. 2. 3. or 1) 2) 3)) format, up to 99 (which of course need to be restricted in whatever way) options are allowed. When written in alphabets, no change. In the quick poll button, the first letter of each option, instead of A/B/C, is shown.

@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hiroshisuga hiroshisuga changed the title Quick poll with text options Quick poll showing options (up to 99 items) Jun 18, 2021
@hiroshisuga hiroshisuga changed the title Quick poll showing options (up to 99 items) Quick poll showing option texts (up to 99 items) Jun 20, 2021
@github-actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@hiroshisuga
Copy link
Contributor Author

hiroshisuga commented Jul 3, 2021

Currently it shows the text answers for all options by making a "custom poll". And the quick polling label in the presentation toolbar picks up the first letter of each answer. I found this way better because students can think the answer by seeing the text answers, not by seeing simple A, B, C, etc.

名称未設定 1のコピー

@hiroshisuga
Copy link
Contributor Author

After v2.3.5, this can be replaced with #12713, which got conflicted with #12692.

@hiroshisuga hiroshisuga closed this Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant