-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick poll showing option texts (up to 99 items) #12590
Quick poll showing option texts (up to 99 items) #12590
Conversation
I changed this to draft. Now, when the polling options are written in numbering (ie, 1. 2. 3. or 1) 2) 3)) format, up to 99 (which of course need to be restricted in whatever way) options are allowed. When written in alphabets, no change. In the quick poll button, the first letter of each option, instead of A/B/C, is shown. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This pull request has conflicts ☹ |
Currently it shows the text answers for all options by making a "custom poll". And the quick polling label in the presentation toolbar picks up the first letter of each answer. I found this way better because students can think the answer by seeing the text answers, not by seeing simple A, B, C, etc. |
What does this PR do?
Shows option texts for quick polling.
This is a resubmission of #10854, which has been broken after mistakenly following the 2.4.x development.
Closes Issue(s)
closes #10631 , Related to #10771
Motivation
Current quick polling does not show the option (answer) text, and sometimes hides the slide (where the questions and options are written) on the smartphone, so students cannot answer when they forget their choice. I, as a professor, have to warn them "Do you already know your choice? Please don't forget it, OK, let's move to the poll, put your choice before you forget it" ;-)
This PR enables BBB to read the slide text and show the poll option texts, by simply using the BBB's custom polling function.
At last, I've realised that BBB accepts 6 options in one place, while accepting up to 5 options in another. I modified the numChar variable in quick-poll-dropdown/component.jsx to accept up to 6 options.
More
I have posted another PR (#10855) doing the same thing for BBB 2.2, just in case somebody finds it useful.