Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linefeed for polling option #12607

Merged
merged 1 commit into from Jul 2, 2021

Conversation

hiroshisuga
Copy link
Contributor

@hiroshisuga hiroshisuga commented Jun 17, 2021

What does this PR do?

Remove linefeed letters from the yes / no (/abstention) options for quick poll.

Motivation

For some Asian languages such as Japanese, words are not separated by spaces. Thus even the word "abstention" can be folded in two lines (i.e., abs \n tention) . This leads to a failure of parsing the slide text for the quick polling.

In the following figure, はい / いいえ / どちらでもない corresponds to Yes / No / Abstention. Note that "Abstention" is not parsed correctly.
poll

@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@antobinary antobinary added this to the Release 2.3 milestone Jun 17, 2021
@antobinary antobinary merged commit 1b8fea8 into bigbluebutton:v2.3.x-release Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants