Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check for correct directory before deploying bbb-html5 #12721

Merged
merged 1 commit into from Jul 5, 2021

Conversation

antobinary
Copy link
Member

What does this PR do?

In #12589 @oktab1 raises a good point that depending on the dev env setup, the directory (absolute location) might be incorrect. In this PR I add a check, and early exit in case the setup is incorrect.

Motivation

@oktab1 had a different username
In one of my setups https://github.com/bigbluebutton/docker-dev the directory is /home/bigbluebutton/src/bigbluebutton-html5...

@antobinary antobinary added this to the Release 2.3 milestone Jul 5, 2021
@antobinary antobinary merged commit 5f71d53 into bigbluebutton:v2.3.x-release Jul 5, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@antobinary antobinary deleted the 12589 branch October 29, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant