refactor: Add a more accessible dropdown menu #12745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
ramonlsouza
reviewed
Jul 20, 2021
Comment on lines
+21
to
+22
| //Used to switch to mobile view | ||
| const MAX_WIDTH = 640; |
There was a problem hiding this comment.
We have a helper that could be used here to check for mobile devices instead of checking the window size.
There was a problem hiding this comment.
Yeah I saw the utility to check for mobile, the problem with using that helper is that it excludes regular browsers that are resized to mobile sizes.
ramonlsouza
approved these changes
Jul 21, 2021
antobinary
changed the title
|
was this RP tested with RTL layout. ? |
It was not. I just checked it again and released a fix for the issue you created. Thanks! |
antobinary
added a commit
to antobinary/bigbluebutton
that referenced
this pull request
Jul 31, 2021
antobinary
added a commit
that referenced
this pull request
Jul 31, 2021
chore: missing package-lock.json changes from #12745
This was referenced Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add's a more accessible / simplified dropdown menu than the current implementation.
Closes Issue(s)
#12573, #12574