Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: actions bar size calculation - new layouts #12807

Merged
merged 3 commits into from Jul 27, 2021

Conversation

ramonlsouza
Copy link
Member

What does this PR do?

Adds new values for actions bar wrapper and inner height based on font-size and padding, preventing actions bar from being too close to the bottom of the screen

before

Screenshot from 2021-07-22 11-45-00

after

Screenshot from 2021-07-22 11-44-40

@antobinary
Copy link
Member

Did you try it out as presenter with presentation minimized (extra button)? And with screenshare button (on desktop) And I recall there was at least one more button... just making sure there's no overlap

@ramonlsouza
Copy link
Member Author

ramonlsouza commented Jul 22, 2021

Did you try it out as presenter with presentation minimized (extra button)? And with screenshare button (on desktop) And I recall there was at least one more button... just making sure there's no overlap

This PR should only affect vertical size, width should stay the same (padding value is based on legacy layout).

Here's a screenshot of the actions bar with minimized presentation and screenshare button:

Screenshot from 2021-07-22 13-04-37

@github-actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
78.8% 78.8% Duplication

@antobinary
Copy link
Member

Cool, thanks! I guess the screenshots width discrepancy misled me... ☺️

@antobinary antobinary added this to the Release 2.4 milestone Jul 23, 2021
@antobinary antobinary merged commit 9e644e8 into bigbluebutton:develop Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants