fix: Announce new private chat messages in screenreader #12854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Care: Backporting of this to 2.3.x would only close part of the underlying issue as there seem to be some more problems in 2.3.x: further messages aren't being announced |
|
Announcement now includes chat name to distinguish announcements from different private chats. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
thanks @mtsonline for finding the bug and helping me testing :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the problem that screenreader doesn't announce when a new private chat has been started.
Also fixes the minor problem that singular and plural language strings were swapped.
If new private message pops up screenreader now announces the name of the chat (thus the username) and the new messages count. Note that I changed the language key in the singular case to be not injectable because this is needed in, e. g., German language where we have a different word for "1" in this case :-)
Closes Issue(s)
Closes #12845
Motivation
BBB should be as good as possible :-)
More
I'm pretty unexperienced in aria things, so not sure if this is the best way to handle this but it fixes the problem and all tests I did with nvda seemed to be fine.