Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow numerical boolean values #12862

Merged
merged 1 commit into from Jul 29, 2021
Merged

fix: Allow numerical boolean values #12862

merged 1 commit into from Jul 29, 2021

Conversation

paultrudel
Copy link
Collaborator

What does this PR do?

Modified isBooleanValidator to consider '0' and '1' as valid boolean values.

@antobinary antobinary added this to the Release 2.3 milestone Jul 29, 2021
@antobinary antobinary merged commit 8ca63a2 into bigbluebutton:develop Jul 29, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
11.5% 11.5% Duplication

@antobinary antobinary changed the title Allow numerical boolean values fix: Allow numerical boolean values Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paultrudel @antobinary