Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audio): improvements in audio logging #12899

Merged

Conversation

mariogasparoni
Copy link
Collaborator

  1. Removed duplicated error log messages in audio bridge.
  2. Fixed false positive alerts of 1005 errors.

Fully tested across multiple devices, no regressions found.

We now let audio-manager log errors, using the specified error code.
These errors are still logged in bridge layer, but as a warning.
This commit doens't change error codes behavior, they are still being
logged as errors and with the same code numbers.
After reconnecting (with 1007 or 1005), user may gets 1005 when meeting
is ended by moderator.
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@antobinary antobinary added this to the Release 2.3 milestone Aug 3, 2021
@antobinary antobinary merged commit 4ea0183 into bigbluebutton:v2.3.x-release Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants