Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check for users before grabbing breakout url #12905

Merged
merged 1 commit into from Aug 4, 2021

Conversation

antobinary
Copy link
Member

@antobinary antobinary commented Aug 4, 2021

What does this PR do?

Fixes a crash incroduced by #12871 - where if no users were assigned to breakouts (for example if allowing viewers to pick their own room) the viewer's client would crash due to not handling the case of no users in the structure where we look for redirectToHtml5JoinURL

Closes Issue(s)

Closes #12901

@antobinary antobinary added this to the Release 2.3 milestone Aug 4, 2021
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@antobinary antobinary merged commit a6c5db9 into bigbluebutton:v2.3.x-release Aug 4, 2021
@antobinary antobinary deleted the fix-12901 branch October 29, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant