fix: Keyboard Access To Assign Users To Breakout Room Broken #13010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KDSBrowne
suggested changes
Aug 16, 2021
| @@ -871,6 +871,7 @@ class BreakoutRoom extends PureComponent { | |||
| return this.getUserByRoom(room) | |||
| .map((user) => ( | |||
| <p | |||
| tabIndex={0} | |||
There was a problem hiding this comment.
Setting the tabIndex's to 0 for the names in the list will force a keyboard user into tabbing through each name in a list before being able to move to the next. This can be problematic with a lot of users in the list. We should set this tabIndex to -1.
|
Kudos, SonarCloud Quality Gate passed!
|
KDSBrowne
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Restores keyboard access in breakout room modal.
Closes Issue(s)
Closes #13003