Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webcam): key list not provided #13053

Merged
merged 1 commit into from Aug 23, 2021

Conversation

pedrobmarin
Copy link
Collaborator

userName is a list, and its contents must have an unique key.

Warning: Each child in a list should have a unique "key" prop.

Check the render method of `UserName`. See https://fb.me/react-warning-keys for more information.
    in span (created by UserName)
    in UserName (created by UserDropdown)
    in div (created by UserDropdown)
    in div (created by UserDropdown)
    in div (created by UserDropdown)
    in div (created by BBBMenu)
    in div (created by BBBMenu)
    in BBBMenu (created by Context.Consumer)
    in injectIntl(BBBMenu) (created by UserDropdown)
    in UserDropdown (created by Context.Consumer)

To Reproduce
Steps to reproduce the behavior:

  1. Join as desktop user
  2. Join as mobile user
  3. The mobile user then shares his webcam
  4. The desktop user now see two labels underneath
    his name: Webcam | Mobile
  5. The desktop user's console shows a warning

cc @frankemax

userName is a list, and its contents must have an unique key.
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pedrobmarin pedrobmarin merged commit 0c82964 into bigbluebutton:develop Aug 23, 2021
@pedrobmarin pedrobmarin deleted the f-w-klnp branch August 23, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants