Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove unused testing dependencies #13087

Merged

Conversation

MaximKhlobystov
Copy link
Collaborator

What does this PR do?

This PR removes two unused testing dependencies (puppeteer and dotenv) from the main package.json.

Motivation

puppeteer and dotenv from bigbluebutton-html5/package.json are not being used. bigbluebutton-tests/puppeteer/package.json is currently used for testing, so there's no need to download Chromium twice (puppeteer). chai dependency stays inside bigbluebutton-html5, because it is used for server-side unit testing.

@sonarcloud
Copy link

sonarcloud bot commented Aug 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@antobinary antobinary merged commit ea98d34 into bigbluebutton:develop Aug 27, 2021
@antobinary antobinary added this to the Release 2.4 milestone Aug 27, 2021
@antobinary antobinary changed the title Remove unused testing dependencies test: Remove unused testing dependencies Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants