Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix public chat being cleared when starting a new private chat #13193

Conversation

Tainan404
Copy link
Member

What does this PR do?

When a viewer was promoted to moderator, and after that the user starting a new private chat thae clear steam was called deleting the messages, now the clear stream messages is only called when the user changes the role keeping the messages when the new chat is created.

Closes Issue(s)

Closes #13192

@sonarcloud
Copy link

sonarcloud bot commented Sep 10, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

Copy link
Contributor

@jfsiebel jfsiebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antobinary antobinary added this to the Release 2.4 milestone Sep 13, 2021
@antobinary antobinary changed the base branch from develop to v2.4.x-release September 13, 2021 17:53
@antobinary antobinary changed the title Fix public chat being cleared when starting a new private chat fix: Fix public chat being cleared when starting a new private chat Sep 13, 2021
@antobinary antobinary merged commit 65cc2bc into bigbluebutton:v2.4.x-release Sep 13, 2021
ramonlsouza added a commit to ramonlsouza/bigbluebutton that referenced this pull request Oct 7, 2021
ramonlsouza added a commit to ramonlsouza/bigbluebutton that referenced this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promoted user initiating chat leads to losing the public chat for that user
3 participants