Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Adds RTL direction support in Learning Dashboard #13222

Conversation

gustavotrott
Copy link
Collaborator

This PR solves #13162

  • Set RTL direction to Dashboard when using one of the following languages: ar, dv, fa, he

image

@github-actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@ali-alhaidary
Copy link

Is app.learningDashboard.participantsTable.colActivityScore key in en.json merget yet?
As I can see that 'ACTIVITY SCORE' is still in english. #13159

@PhMemmel
Copy link
Contributor

@ali-alhaidary Yes, that should be fixed via #13213. If you want to test this, you will have to adapt your temporary ar.json, because the language string keys have been renamed recently. It's app.learningDashboard.usersTable.colActivityScore now. Double check transifex if the newly introduced (because renamed) keys have been translated and manually deploy the newest ar.json directly from transifex as these new changes have not been pulled into github yet.

@ali-alhaidary
Copy link

Thanks @PhMemmel , yes, it is there and translated...

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@antobinary antobinary added this to the Release 2.4 milestone Sep 16, 2021
@antobinary antobinary merged commit fa57cab into bigbluebutton:v2.4.x-release Sep 16, 2021
@antobinary antobinary changed the title Adds RTL direction support in Learning Dashboard refactor: Adds RTL direction support in Learning Dashboard Sep 21, 2021
@Rahimimojtaba
Copy link

@antobinary @gustavotrott
It's only working on AR language. For other RTL languages such as fa_IR not working properly.

@antobinary
Copy link
Member

@Rahimimojtaba could you please share what you see and please circle which part of the UI is not properly done? Keep in mind that the strings need to be translated to display correctly

@Rahimimojtaba
Copy link

Rahimimojtaba commented Oct 13, 2021

Dear @antobinary
It's really clear. This fix only work for Arabic language. It's not working for other RTL languages, such as fa_IR.
You can create a meeting with fa_IR language and check the Learning dashboard, it's still LTR.
It should be RTL.
Also I know about the translation and I don't mean that one.

@gustavotrott
Copy link
Collaborator Author

Hey @Rahimimojtaba,
you are right, fa_IR lang was not added in the RTL list.
This is because the list was copied the same of BBB client.

const RTL_LANGUAGES = ['ar', 'dv', 'fa', 'he'];

Is this problem happening also in BBB client? Or only in the Dashboard?

@Rahimimojtaba
Copy link

Dear @gustavotrott
Thanks for your reply and following up the issue.
No, it just happen for Learning Dashboard. BBB Client is OK.
In BBB Client, we only have problem for welcome message that is not fully show. I reported here #13160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants