New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Learning Dashboard line wrap fix #13305
Merged
antobinary
merged 13 commits into
bigbluebutton:develop
from
hiroshisuga:dashboardwrapfix
Sep 30, 2021
Merged
style: Learning Dashboard line wrap fix #13305
antobinary
merged 13 commits into
bigbluebutton:develop
from
hiroshisuga:dashboardwrapfix
Sep 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accumulated PRs
accumulated PRs
accumulated PRs
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
LGTM. Thanks @hiroshisuga! |
antobinary
changed the title
Learning Dashboard line wrap fix
style: Learning Dashboard line wrap fix
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the line wrapping policy as it might be originally intended.
Closes Issue(s)
Closes #13297
Motivation
I posted the PR #13297 because of a problem in Japanese letter which is hidden by its own background when wrapped in multiple lines. But after that post I realised that the table was originally designed without wrapping. For this purpose, the table CSS is currently defined as "whitespace-no-wrap", but I think "whitespace-nowrap" is the correct one.
More