Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Improve init function, fix code warnings, rename folders and fix test paths #13358

Merged
merged 9 commits into from Oct 4, 2021
Merged

test: Improve init function, fix code warnings, rename folders and fix test paths #13358

merged 9 commits into from Oct 4, 2021

Conversation

antonbsa
Copy link
Member

@antonbsa antonbsa commented Oct 1, 2021

What does this PR do?

  • Simplify the use of init function;
  • Move params.js to core folder;
  • Add timeout to waitForFunctions;
  • Fix code warnings;
  • Rename the notes and events folder;
  • Fix tests paths in all.test

@sonarcloud
Copy link

sonarcloud bot commented Oct 1, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
12.3% 12.3% Duplication

@antonbsa antonbsa mentioned this pull request Oct 1, 2021
Closed
@antobinary antobinary added this to the Release 2.4 milestone Oct 4, 2021
@antobinary antobinary merged commit 58f30dd into bigbluebutton:v2.4.x-release Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximKhlobystov MaximKhlobystov MaximKhlobystov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@antonbsa @MaximKhlobystov @antobinary