Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Let bbb try to open BreakoutRoom automatically (when receive the URL asked by user) #13439

Conversation

gustavotrott
Copy link
Collaborator

@gustavotrott gustavotrott commented Oct 7, 2021

Fix #13354
Once #13363 reduced the time to generate Breakout URL.

This PR does not change the current steps to open a Breakout Room.
It only include a try to open the URL automatically.

This "automatically opener" was removed to avoid problems with PopupBlocker of the browsers.
But after a lot of tests, the try to open automatically seems to worth:

  • When the URL is opened automatically is very convenient for the users.
  • When Popup is blocked, the warning is very unobtrusive and doesn't disturbs.
  • Users can "allow popups to this site" and benefit of open automatically afterwards.

Result of tests:

  • In Chrome, the Breakout Room will most of times be opened automatically without problems.
  • In Firefox, the user will usually have to manually click to "Join room" or add exception to "Allow this site".

Example of tests:

  • Chrome opening automatically! (99% of times)
    chrome-ok

  • Chrome Popup blocked and user click manually "Join room"
    chrome-allow

  • Chrome Popup blocked and user "Allow this site" to open popups
    chrome-allow-popup

  • Firefox Popup blocked and user click manually "Join room"
    firefox-join

  • Firefox Popup blocked and user "Allow this site" to open popups
    firefox-allow

@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

No Coverage information No Coverage information
18.3% 18.3% Duplication

@antobinary antobinary added this to the Release 2.4 milestone Oct 7, 2021
@antobinary antobinary changed the title Let bbb try to open BreakoutRoom automatically (when receive the URL asked by user) refactor: Let bbb try to open BreakoutRoom automatically (when receive the URL asked by user) Oct 7, 2021
@antobinary antobinary merged commit b86b5d2 into bigbluebutton:v2.4.x-release Oct 7, 2021
@gustavotrott gustavotrott deleted the breakout-room-join-automatically branch March 11, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants