build: Update bbb-webrtc-sfu packaging to include mediasoup #13451
Conversation
... drop build artifacts from compiling mediasoup. This reduces package size from ~ 54 MB to ~ 12 MB. Additionally this drops the `npm rebuild` command from the after-install script. It should not be necessary to recompile stuff during installation. To ensure a clean `node_modules` directory, it will be cleaned in the before-install script.
|
Thanks for the PR!
Now that RC2 is out I should be tagging a new SFU version early next week with mediasoup et al as production dependencies. So we should preferably merge this after that new tag is available imho. |
|
@prlanzarin we could merge now and update as the new tag becomes available. What would you prefer? |
Works as long as a development build doesn't end in a 2.4 release. |
|
https://github.com/bigbluebutton/bbb-webrtc-sfu/releases/tag/v2.6.0-beta.5 mediasoup et al were moved to prod dependencies in beta.5 |
Co-authored-by: Paulo Lanzarin <4529051+prlanzarin@users.noreply.github.com>
Co-authored-by: Paulo Lanzarin <4529051+prlanzarin@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
antobinary
changed the title
What does this PR do?
Include mediasoup in bbb-webrtc-sfu build. It ships javascript files and the worker binary
Motivation
I want @prlanzarin 's awesome media server improvements
More
Additionally this drops the
npm rebuildcommand from the after-install script. It should not be necessary to recompile stuff duringinstallation. To ensure a clean
node_modulesdirectory, it will be cleaned in the before-install script. There might be left over files from previousnpm reinstallcalls from older BBB versions so get rid of them.As soon as mediasoup is a production dependency in the bbb-webrtc-sfu sources,
npm installcan be used in production mode again