Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Dashboard support for users grouped by extId #13852

Conversation

JoVictorNunes
Copy link
Collaborator

What does this PR do?

This PR refactors the Learning Dashboard for supporting the grouping by extId rather than intId. Only one row per user will be displayed in the tables.

Captura de tela de 2021-12-07 16-58-08

Captura de tela de 2021-12-07 16-58-19

Motivation

With #13826, the info will be stored using extId rather than intId. So, this PR adds the necessary Dashboard changes for matching that implementation.

@JoVictorNunes JoVictorNunes marked this pull request as draft December 7, 2021 20:18
@antobinary antobinary added this to the Release 2.4 milestone Dec 7, 2021
@JoVictorNunes JoVictorNunes marked this pull request as ready for review December 9, 2021 12:10
@gustavotrott
Copy link
Collaborator

Hey @JoVictorNunes, it is working very well!

I will need to ask you to make just one adjustment.
There is a case when one user can join the meeting from different devices at the same time. In this case, we want two rows in the Dashboard.. cause it would be a mess to merge/handle two webcams simultaneously, two devices speaking and so on...
In short, we can have two users using the same extId and because of that we can't use the extId as key to summarize anything (e.g usersActivityScore[a.extId]).
There is a new prop called userKey that is unique and can be used instead.

I am attaching an Json with this case.
learning_dashboard_data.zip

@JoVictorNunes JoVictorNunes marked this pull request as draft December 9, 2021 20:55
@JoVictorNunes JoVictorNunes marked this pull request as ready for review December 10, 2021 13:45
@sonarcloud
Copy link

sonarcloud bot commented Dec 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@gustavotrott gustavotrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@gustavotrott gustavotrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antobinary antobinary merged commit 1274bfb into bigbluebutton:v2.4.x-release Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants