-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Dashboard support for users grouped by extId #13852
refactor: Dashboard support for users grouped by extId #13852
Conversation
dc3b165
to
d39d9ec
Compare
Hey @JoVictorNunes, it is working very well! I will need to ask you to make just one adjustment. I am attaching an Json with this case. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does this PR do?
This PR refactors the Learning Dashboard for supporting the grouping by
extId
rather thanintId
. Only one row per user will be displayed in the tables.Motivation
With #13826, the info will be stored using
extId
rather thanintId
. So, this PR adds the necessary Dashboard changes for matching that implementation.