Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(webcams): add option to allow moderators to close another user's webcams #13915

Merged
merged 2 commits into from
Dec 15, 2021
Merged

feat(webcams): add option to allow moderators to close another user's webcams #13915

merged 2 commits into from
Dec 15, 2021

Conversation

prlanzarin
Copy link
Member

What does this PR do?

  • Includes a new create param/bbb-web conf called allowModsToEjectCameras
    • False by default, controls the availability of this feature

Closes Issue(s)

There's an issue out there. I'll edit this description with it later.

Additional information

  • The button is located in the user-list's user options dropdown (alongside microphone mute et al)
  • Closes all webcams shared by the target user
  • Disabled in breakout rooms

@prlanzarin
feat(webcams): server-side logic to allow moderators to close user's …
21c124b 
…webcams

Includes a new create param/web conf called allowModsToEjectCameras, false by
default.

Ejection does not work in breakout rooms or with non-mod users

Ejection closes _all_ webcams shared by the target user
@antobinary antobinary added this to the Release 2.4 milestone Dec 13, 2021
@prlanzarin prlanzarin marked this pull request as ready for review December 14, 2021 13:25
@pedrobmarin pedrobmarin self-requested a review December 15, 2021 12:50
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

pedrobmarin
pedrobmarin approved these changes Dec 15, 2021
View reviewed changes
Copy link
Collaborator

@pedrobmarin pedrobmarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

It might be missing some kind of feedback for the user who had the camera ejected. But I don't see any issue on making the UX improvements later on.

@antobinary antobinary merged commit b0c66ca into bigbluebutton:v2.4.x-release Dec 15, 2021
@prlanzarin prlanzarin mentioned this pull request Dec 22, 2021
Merged
@prlanzarin prlanzarin mentioned this pull request Jan 3, 2022
Open
4 tasks
@antobinary antobinary mentioned this pull request Jan 10, 2022
Closed
@prlanzarin prlanzarin mentioned this pull request May 4, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobmarin pedrobmarin pedrobmarin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prlanzarin @pedrobmarin @antobinary