fix: Add a message for when the guest isn't valid #14334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobmarin
reviewed
Feb 11, 2022
bbb-common-web/src/main/java/org/bigbluebutton/api/domain/Meeting.java
Outdated
Show resolved
Hide resolved
pedrobmarin
reviewed
Feb 11, 2022
bbb-common-web/src/main/java/org/bigbluebutton/api/domain/RegisteredUser.java
Outdated
Show resolved
Hide resolved
pedrobmarin
reviewed
Feb 11, 2022
bbb-common-web/src/main/java/org/bigbluebutton/api/domain/RegisteredUser.java
Outdated
Show resolved
Hide resolved
pedrobmarin
reviewed
Feb 11, 2022
bigbluebutton-web/grails-app/controllers/org/bigbluebutton/web/controllers/ApiController.groovy
Show resolved
Hide resolved
antobinary
reviewed
Feb 16, 2022
akka-bbb-apps/.bsp/sbt.json
Outdated
| @@ -0,0 +1 @@ | |||
| {"name":"sbt","version":"1.5.2","bspVersion":"2.0.0-M5","languages":["scala"],"argv":["/usr/lib/jvm/java-8-openjdk-amd64/jre/bin/java","-Xms100m","-Xmx100m","-classpath","/home/dev/.local/share/JetBrains/IdeaIC2021.3/Scala/launcher/sbt-launch.jar","xsbt.boot.Boot","-bsp","--sbt-launch-jar=/home/dev/.local/share/JetBrains/IdeaIC2021.3/Scala/launcher/sbt-launch.jar"]} | |||
There was a problem hiding this comment.
Please add to .gitignore and drop from PR
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Feb 18, 2022
antobinary
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new field to registered user for when he leaves the lobby and use it to notify the user about a invalid request, it's meant for users who left the guest lobby and returned and users with connection issues
Motivation
Before this PR the user isn't notified about the invalidation of the requests and keep trying to join the meeting, but the moderator isn't nofied about the new attempts. Now the user receives a notifications that his request is invalid
How to test