Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(audio): remove duplicated loadBridges method definition #14434

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

prlanzarin
Copy link
Member

@prlanzarin prlanzarin commented Feb 22, 2022

What does this PR do?

Seems to have been introduced by a partial merge commit (v2.4 -> v2.5)

There were a bunch of style changes introduced by that partial commit as well; I kept those changes to avoid introducing further conflicts between v2.4-2.5...

Also: the duplicated definition was a stale one and it was overriding the fresh definition.

Closes Issue(s)

n/a

Motivation

n/a

More

n/a

Seems to have been introduced by a partial merge commit

There were a bunch of style changes introduced by that partial commit as well; I kept those changes to avoid introducing further conflicts between v2.4-2.5...
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@antobinary antobinary added this to the Release 2.5 milestone Feb 22, 2022
@antobinary antobinary merged commit 98e8a96 into bigbluebutton:v2.5.x-release Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants