-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webcam): avatar loading #14938
feat(webcam): avatar loading #14938
Conversation
cc @ramonlsouza feel free to assign yourself as a reviewer if you deem appropriate |
@frankemax maybe you should extend the user-list avatar styles in a decoupled style sheet in video-list-etc? I think that may be feasible (and recommendable) from a very brief vertical glance since most of the changes done in the user-list styles are conditional to a |
...uebutton-html5/imports/ui/components/video-provider/video-list/video-list-item/container.jsx
Show resolved
Hide resolved
...uebutton-html5/imports/ui/components/video-provider/video-list/video-list-item/component.jsx
Show resolved
Hide resolved
bigbluebutton-html5/imports/ui/components/video-provider/video-list/video-list-item/styles.js
Show resolved
Hide resolved
@prlanzarin now it's ready for re-review |
Add a new avatar component to video list item Change the design of the components, following the new video list idea Add icons related to the state of the user
Add correct prop types to user-status
Fix spinner Add unhealthy stream filter to the avatar
Fix mirror own webcam not working Probably broke after e45deb5
Fixes an issue that when the user joins with a custom avatar, the talking indicator div ends up covering the avatar image.
61fa545
to
5152ce4
Compare
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good as a first version.
A few pending things (which I discussed with @frankemax) that, IMO, should be addressed in subsequent PRs/patches:
- There can be a tiny gap between the talking indicator frame and the video container corner due to the new border radius
- The user name position was moved to the lower left side as a suggestion of mine to 1) make things easier 2) make the connecting vs connected views have consistent UI element positions. This probably warrants an (N)ACK from @tylercopeland once it lands on some testing server and he gets to use it.
- Avatar user icons (presenter/dial in) do not disappear when the container elements are hidden due to constrained width. They should.
- Review the camera container background color. I found the new one a bit confusing since it's very similar to the client's main background color. But that's my view, so cc @tylercopeland
|
Thanks.
Cool. As a suggestion: one of our designers suggested |
@frankemax Hi this implementation is working fine, but how to modify this in a way that this avatar placeholder will be previewed everytime user disables his/her webcam |
@NarsimaChilkuri And designs here: #13844 (comment) I believe that just changing the HTML5 you can reach a satisfactory result, but you would have to rethink the layout context logic and cameras grid in a way that resembles the proposed designs. Starting with these points #13844 (comment) would be a good start... |
@frankemax can you give me an overview what changes are required to establish the satisfactory result which i need |
@frankemax i need to show placeholder of webcam connecting only if you stop video webcam |
@narsimachilkuri45 #13844 (comment) BUT, if you want to try on your own, I'm doing this for the mobile-sdk right now, maybe this PR will inspire you: |
@frankemax it is for mobile sdk right, if possible can you guide me for the changes in bigbluebutton-html5 for web version, so i can implement it over there |
What does this PR do?
Add a new avatar component to video list item
Change the design of the components, following the new video list idea suggested here #13844 (comment)
Add icons related to the state of the user: presenter / dialIn
Closes Issue(s)
Closes #12481
Points to review
Screenshots
Presenter / dial In / moderator / client
When a user joins in a meeting, he will see this during of other users webcam loading:
loadingInAction2.mp4
Extended loading
loading.mp4
Talking indicator
TalkingIndicator.mp4
Squeezed
Reconnecting animation
Peek.2022-05-05.15-21.mp4
Avatar emoji status
Peek.2022-05-05.16-50.mp4