style: Removing and alinging dropdowns items. #15048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactoring code ...
|
Kudos, SonarCloud Quality Gate passed!
|
ramonlsouza
approved these changes
May 20, 2022
antobinary
changed the title
|
@ramonlsouza Could you add more spacing around the menus
The text is looking a bit too tight against the top, bottom, left, and right of the pop-up menu. |
|
@ffdixon Sure! I will create a new PR increasing the spacing a bit so we have something similar to what it was before the latest changes, but without the white borders... like this:
|
This was referenced May 23, 2022
|
closes #15031 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR the dropdown items had additional margin/padding on hover/active.
and the dropdown icons weren't vertically (center) aligned with the text
Now, the dropdown items don't have any white spaces inside and the dropdown icons are vertically centered.
