Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: chat and user-list export file name date string #15050

Conversation

JoVictorNunes
Copy link
Collaborator

@JoVictorNunes JoVictorNunes commented May 20, 2022

What does this PR do?

Forces hour/minutes/month/day of the date in export file name of both chat and user-list to always have two digits by padding with 0's.

Before:
bbb-random-3325220[users-list]_2022-5-20_12-9.txt

After
bbb-random-3325220[users-list]_2022-05-20_12-09.txt

Closes Issue(s)

None

Motivation

Standardization.

@sonarcloud
Copy link

sonarcloud bot commented May 20, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JoVictorNunes JoVictorNunes marked this pull request as ready for review May 20, 2022 16:58
@antobinary antobinary added this to the Release 2.5 milestone May 20, 2022
@antobinary
Copy link
Member

Inspired by @olifre's #14684
Thanks @olifre !!

@olifre
Copy link

olifre commented May 20, 2022

Thanks @antobinary , that does indeed look like a nicer way to do it and reuse the code in multiple places 👍 .

@ramonlsouza ramonlsouza merged commit 6b915c1 into bigbluebutton:v2.5.x-release May 23, 2022
@antobinary antobinary changed the title improvement: chat and user-list export file name date string refactor: chat and user-list export file name date string May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants