Fix rap-enqueue.rb to load gems with bundler #15116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In BBB 2.5, we switched the recording system to use bundled gems included privately in the recording package, rather than installed system-wide. The rap-enqueue.rb script needs to be updated to load the bundler gems. According to bundler devs, setting the BUNDLE_GEMFILE environement variable is the supported way to tell bundler where to find it (otherwise bundler will search starting at the current working directory - which in the case of rap-enqueue.rb is probably nowhere near the Gemfile). Use a relative path from the directory where the script is located so it can be run both when installed and from a development environment. Switch the script interpreter to use /usr/bin/env to load ruby from the path. Doesn't make a difference in the installed package, but it makes testing on development systems with multiple ruby environments easier. Fixes bigbluebutton#15085
|
Kudos, SonarCloud Quality Gate passed!
|
GuiLeme
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In BBB 2.5, we switched the recording system to use bundled gems
included privately in the recording package, rather than installed
system-wide. The rap-enqueue.rb script needs to be updated to load the
bundler gems.
According to bundler devs, setting the BUNDLE_GEMFILE environement
variable is the supported way to tell bundler where to find it
(otherwise bundler will search starting at the current working directory,
which in the case of rap-enqueue.rb is probably nowhere near the
Gemfile).
Use a relative path from the directory where the script is located so it
can be run both when installed and from a development environment.
Switch the script interpreter to use /usr/bin/env to load ruby from the
path. Doesn't make a difference in the installed package, but it makes
testing on development systems with multiple ruby environments easier.
Fixes #15085