Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pad line space not showing for viewers #15128

Merged

Conversation

gabriellpr
Copy link
Collaborator

Before this PR when the moderator skips a line inside the shared notes it doesn't reflect as it should for the viewers.
Screenshot from 2022-06-03 11-03-56

Screenshot from 2022-06-03 10-53-40

Now, the viewers can see the shared notes exactly as the moderator typed.

Screenshot from 2022-06-03 11-03-56

Screenshot from 2022-06-03 10-56-06
.

Closes #14999

@pedrobmarin
Copy link
Collaborator

Can you validate this change does not affect this previous fix #14799 ?

@antobinary antobinary added this to the Release 2.5 milestone Jun 3, 2022
@gabriellpr
Copy link
Collaborator Author

Hello Pedro, so I tested here and it doesn't affect this PR #14799 .

Screenshot from 2022-06-03 12-08-44

flex column removed
@gabriellpr gabriellpr marked this pull request as ready for review June 3, 2022 15:11
@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ramonlsouza ramonlsouza merged commit c489303 into bigbluebutton:v2.5.x-release Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants