Refactor toast in presentation-uploader #15474
Conversation
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
…lemented the solution to shared notes.
…ed toast controller
| // tmpIdconvertingPresentations = UploadingPresentations.find({}).fetch().filter(p => tmpIdconvertingPresentations.includes(p.tmpPresId)) | ||
| // .map(p => p.tmpPresId) |
There was a problem hiding this comment.
| // tmpIdconvertingPresentations = UploadingPresentations.find({}).fetch().filter(p => tmpIdconvertingPresentations.includes(p.tmpPresId)) | |
| // .map(p => p.tmpPresId) |
| .map(p => UploadingPresentations.remove({tmpPresId: p.tmpPresId})); | ||
| // Remove all presentations from the uploading collection if they are already | ||
| // converting. | ||
| // UploadingPresentations.remove({tmpPresId: {$all: tmpIdconvertingPresentations}}); |
There was a problem hiding this comment.
| // UploadingPresentations.remove({tmpPresId: {$all: tmpIdconvertingPresentations}}); |
|
|
||
| // Fazer o onConversion modificar a upload e ver o que mais da pra fazer |
There was a problem hiding this comment.
| // Fazer o onConversion modificar a upload e ver o que mais da pra fazer |
bigbluebutton-html5/imports/ui/components/presentation/presentation-uploader/component.jsx
Outdated
Show resolved
Hide resolved
Co-authored-by: João Victor Nunes <62393923+JoVictorNunes@users.noreply.github.com>
fix: show conversion process info in toast
…aryPresentationId's name
…button into apply-toast-shared-notes
GuiLeme
requested review from
gustavotrott and
JoVictorNunes
and removed request for
gabriellpr,
antonbsa,
gustavotrott and
JoVictorNunes
There was a problem hiding this comment.
The client part seems all ok! Let's hold on @gustavotrott's review on the backend part.
There was a problem hiding this comment.
I can still reproduce the problem related in #15259.
Although this PR brings great improvements to the pres-upload toast! If you want, we can merge this changes and try to fix the problem in a subsequent PR. It seems to be related with Tldraw component only.
|
Kudos, SonarCloud Quality Gate passed!
|
What does this PR do?
It refactors the toast to not depend on the presentation-uploader component, instead, it will be a separate component that will watch any presentation coming from the service of presentation uploader, and so, can be used in every ocasion the client wants to send a document. Moreover, it will notify the presenter of possible conversions that might be occurring, since it is watching the
Presentationscollection as well.Closes Issue(s)
#15505
More
Credits and huge thanks to @JoVictorNunes, who made a patch to insert the count of pages in the conversion part, closing issue #15505:
GuiLeme#6