Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preloaded fonts being requested again #15562

Merged

Conversation

ramonlsouza
Copy link
Member

What does this PR do?

  • adjusts build script, so v=VERSION is replaced by the correct build number.
  • appends version number to font urls in fonts.css file, preventing the following warning from appearing in browser console:

The resource was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate as value and it is preloaded intentionally

@ramonlsouza ramonlsouza added this to the Release 2.5 milestone Aug 18, 2022
@antobinary
Copy link
Member

Excellent! That would explain why I was seing the fonts pulled repeatedly!

ramonlsouza and others added 2 commits August 26, 2022 09:31
Co-authored-by: Anton Georgiev <antobinary@users.noreply.github.com>
Co-authored-by: Anton Georgiev <antobinary@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ramonlsouza ramonlsouza merged commit ba44e4e into bigbluebutton:v2.5.x-release Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants