Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emojis tests for the public/private chat #15616

Merged
merged 6 commits into from
Sep 20, 2022

Conversation

gabriellpr
Copy link
Collaborator

What does this PR do?

Tests for the emoji picker button and the auto-converted emoji on the public and private chat.

Closes Issue(s)

Closes #15478
Closes #15477

@antobinary antobinary added this to the Release 2.6 milestone Aug 30, 2022
@antonbsa antonbsa self-requested a review August 31, 2022 11:38
Copy link
Member

@antonbsa antonbsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good additions! I'd just say that a check of the copied content is missing (same as what we have in the Copy chat test) in the tests that copy emoji to clipboard

@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
23.0% 23.0% Duplication

@gustavotrott gustavotrott merged commit f3bb17a into bigbluebutton:v2.6.x-release Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants