Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JVM apps stopping to differ from failure #15632

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

antobinary
Copy link
Member

What does this PR do?

  • sets SuccessExitStatus on JVM applications to 143 so that when we stop these services (intentionally) they don't count it as a failure
  • Intructed bbb-fsesl-akka to only start once freeswitch is running and bbb-apps-akka to only start once bbb-fsesl-akka is running. This should avoid some rare-ish cases where slow freeswitch launch would cause a few BBB components ot fail launching

Closes Issue(s)

Closes #none

Motivation

https://serverfault.com/a/695863 for 143

It looked like this before when triggering bbb-conf --stop

root@droplet-1070:~# journalctl -f | grep -i "failed with result"


Sep 01 13:56:48 droplet-1070 systemd[1]: bbb-fsesl-akka.service: Failed with result 'exit-code'.
Sep 01 13:56:48 droplet-1070 systemd[1]: bbb-apps-akka.service: Failed with result 'exit-code'.
Sep 01 13:56:49 droplet-1070 systemd[1]: bbb-web.service: Failed with result 'exit-code'.
Sep 01 13:56:52 droplet-1070 systemd[1]: bbb-rap-resque-worker.service: Failed with result 'exit-code'.

And after these changes:

root@droplet-1070:~# journalctl -f | grep -i "failed with result"
Sep 01 13:56:52 droplet-1070 systemd[1]: bbb-rap-resque-worker.service: Failed with result 'exit-code'.

The remaining one is a bit more complex to resolve and not really causing much noise right now.

More

@antobinary antobinary added this to the Release 2.6 milestone Sep 2, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@antobinary antobinary merged commit a176798 into bigbluebutton:v2.6.x-release Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant